-
Notifications
You must be signed in to change notification settings - Fork 374
feature: scan_progress #73
base: master
Are you sure you want to change the base?
Conversation
- focus progress is now also visible - detect card frame borders get hidden when focus score is to low
Note: The build only fails because the required DMZ changes cannot be fetched since they are not merged yet: card-io/card.io-dmz#30 |
int width = (int) (GUIDE_STROKE_WIDTH / 2 * mScale); | ||
int height = (int) (50 * mScale); | ||
int offset = (int) (10 * mScale); | ||
for ( int i = 0; i < scanProgress; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing is not consistent. Don't put a space before int
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by e0b1376
Maybe we leave the color of the guide frame as defined (GREEN) and do the fancy color effect just on the progress bar... Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30 |
* progress color only applied to progress indicator bar * progress indicator bar elements are now incremential
Like this. Updated the progress color behavior. Guide frame color is now unchanged. Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30 |
It's helpful to track the scan progress state (focus, edge, vseg, hseg, stability...).
It enables additional functionality like visible user feedback guidance
or autofocus trigger once hseg is reached which I have also put
in the pull requests (dmz and android).
This increases user experience because: