Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add support for verify-clients #4

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Add support for verify-clients #4

wants to merge 1 commit into from

Conversation

samuelallan72
Copy link
Contributor

@samuelallan72 samuelallan72 commented Nov 27, 2024 •
edited
Loading

@samuelallan72 samuelallan72 requested a review from a team as a code owner November 27, 2024 02:18
@samuelallan72 samuelallan72 mentioned this pull request Nov 27, 2024
Merged
@samuelallan72
Copy link
Contributor Author

Note: blocked on tailscale/tailscale#10359

@samuelallan72 samuelallan72 marked this pull request as draft November 27, 2024 07:40
@samuelallan72 samuelallan72 changed the base branch from main to remove-verify November 27, 2024 22:47
@samuelallan72 samuelallan72 changed the title WIP: share the socket with tailscale snap WIP: Add support for verify-clients Nov 27, 2024
Base automatically changed from remove-verify to main November 28, 2024 02:51
@samuelallan72 samuelallan72 force-pushed the socket branch 2 times, most recently from 63f7e2f to 30f1fbd Compare November 29, 2024 01:49
@samuelallan72 samuelallan72 changed the base branch from main to remove-verify-2 November 29, 2024 01:49
Base automatically changed from remove-verify-2 to main December 2, 2024 01:32
samuelallan72 added a commit that referenced this pull request Jan 8, 2025
@samuelallan72
Remove reference to unused config var
5d7bacd 
`verify-clients` is something we'll add at some point - see #4.
But we're blocked on it for now, and can't use it.
It looks like this reference was accidentally left here though.
It must be removed, otherwise the configure hook will fail.
@samuelallan72 samuelallan72 mentioned this pull request Jan 8, 2025
Merged
samuelallan72 added a commit that referenced this pull request Jan 8, 2025
@samuelallan72
Remove reference to unused config var (#18)
73c396e 
`verify-clients` is something we'll add at some point - see #4.
But we're blocked on it for now, and can't use it.
It looks like this reference was accidentally left here though.
It must be removed, otherwise the configure hook will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samuelallan72