Support sending arguments with stacktraces #632
Conversation
GrahamCampbell
changed the title
| $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS & ~DEBUG_BACKTRACE_PROVIDE_OBJECT); | ||
| // Reduce memory usage by omitting args and objects from backtrace by default | ||
| $backtrace = debug_backtrace( | ||
| $config->shouldSendArguments() ? 0 : DEBUG_BACKTRACE_IGNORE_ARGS & ~DEBUG_BACKTRACE_PROVIDE_OBJECT |
There was a problem hiding this comment.
Omitting objects seems to not show any args at all in my testing, so I left it out.
| @@ -89,7 +91,8 @@ public static function fromBacktrace(Configuration $config, array $backtrace, $t | |||
| $topFile, | |||
| $topLine, | |||
| isset($frame['function']) ? $frame['function'] : null, | |||
| isset($frame['class']) ? $frame['class'] : null | |||
| isset($frame['class']) ? $frame['class'] : null, | |||
| $config->shouldSendArguments() && isset($frame['args']) ? $frame['args'] : null | |||
There was a problem hiding this comment.
required to check shouldSendArguments again for xdebug compatibility
|
hey @GrahamCampbell thanks for submitting this! We're going to take a look and review as soon as priorities allow it 👍 |
|
Thanks for the PR. Unfortunately we've decided that we're not going to move forward with this feature for the time being. There are a few wider issues that would need to be addressed such as dashboard updates to ensure long values wrap sensibly, and providing a new API with finer control over redacting data as the arguments are highly likely to contain sensitive data in some applications. We'd need to invest some effort in designing and implementing these changes to fully support this in an acceptable way. We're continuing to monitor interest on the original github issue and may pick this up again in the future when priorities allow. |
Goal
As a developer, I'd like to see the arguments passed to functions in stack trace frames to enable me to better understand what happened and how to reproduce the issue. Closes #519.
Design
The
Configurationclass has a mechanism for toggling if code should be sent. We can copy this design to add support for toggling if argument values should be included. Objects, arrays and resources are represented by noting their type but not their value. Quite a rabbit hole otherwise...Changeset
New
setSendArgumentsandshouldSendArgumentsfunctions. Disabled by default, so no change in functionality for existing users.Testing
Unit tests.