Non-Action xvfb #2976
Merged
Non-Action xvfb #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the e2e tests I saw notification that the
GabrielBB/xvfb-actionwe've been using to run Zui inside X11 in CI has been deprecated. While they point to a maintained replacementcoactions/setup-xvfb, someone points out in coactions/setup-xvfb#21 thatxvfbis now built right into the hosted GitHub Actions Ubuntu Runners. This PR switches us using the built-inxvfbinstead.One of the features of the Action was:
This is why there's a conditional now in
e2e.yml. This is a test run with this branch on all three platforms showing that's working as expected, e..g., video recordings in the artifacts.