Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Add logging #85

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Add logging #85

merged 1 commit into from
Mar 17, 2015

Conversation

msabramo
Copy link
Contributor

to aid in understanding how caniusepython3 works under the hood.

E.g.:

$ caniusepython3 --projects diesel -v
[INFO] 1 top-level projects to check
Finding and checking dependencies ...
...
[INFO] Checking top-level project: diesel ...
[INFO] Locating diesel
[INFO] Dependencies of diesel: [u'http-parser', u'pyopenssl', u'twiggy', u'greenlet', u'flask', u'dnspython']
[INFO] Checking dependency: http-parser ...
[INFO] Checking dependency: pyopenssl ...
[INFO] Checking dependency: twiggy ...
[INFO] Checking dependency: greenlet ...
[INFO] Checking dependency: flask ...
[INFO] Checking dependency: dnspython ...

You need 1 project to transition to Python 3.
Of that 1 project, 1 has no direct dependencies blocking its transition:

  diesel

to aid in understanding how caniusepython3 works under the hood.

E.g.:

    $ caniusepython3 --projects diesel -v
    [INFO] 1 top-level projects to check
    Finding and checking dependencies ...
    ...
    [INFO] Checking top-level project: diesel ...
    [INFO] Locating diesel
    [INFO] Dependencies of diesel: [u'http-parser', u'pyopenssl', u'twiggy', u'greenlet', u'flask', u'dnspython']
    [INFO] Checking dependency: http-parser ...
    [INFO] Checking dependency: pyopenssl ...
    [INFO] Checking dependency: twiggy ...
    [INFO] Checking dependency: greenlet ...
    [INFO] Checking dependency: flask ...
    [INFO] Checking dependency: dnspython ...

    You need 1 project to transition to Python 3.
    Of that 1 project, 1 has no direct dependencies blocking its transition:

      diesel
brettcannon added a commit that referenced this pull request Mar 17, 2015
Emit logging info for checking dependencies
@brettcannon brettcannon merged commit 36760d1 into brettcannon:master Mar 17, 2015
@brettcannon
Copy link
Owner

Thanks!

@@ -97,7 +98,9 @@ def blocking_dependencies(projects, py3_projects):
# can't port.
del reasons[parent]
continue
log.info('Dependencies of {0}: {1}'.format(project, deps))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msabramo Hmm, maybe I'm mistaken but I think this should have been logging parent, not project, isn't it..? (PR224). Sorry for the half-decade ping!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants