Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hail to 0.2.127 #53142

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update hail to 0.2.127 #53142

wants to merge 9 commits into from

Conversation

mjsteinbaugh
Copy link
Member

@mjsteinbaugh mjsteinbaugh commented Jan 8, 2025

Update hail to 0.2.127 (required for gentropy 2.0.1 release in #53099)


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mjsteinbaugh mjsteinbaugh requested a review from raivivek January 8, 2025 17:50
@mjsteinbaugh
Copy link
Member Author

mjsteinbaugh commented Jan 8, 2025

typer module isn't getting picked up in the build correctly:

2025-01-08T18:46:51.4895498Z 18:46:49 �[32mBIOCONDA INFO�[0m (OUT) Installing collected packages: hail�[0m
2025-01-08T18:46:51.4895951Z 18:46:50 �[32mBIOCONDA INFO�[0m (OUT) Successfully installed hail-0.2.127�[0m
2025-01-08T18:46:51.4896427Z 18:46:50 �[32mBIOCONDA INFO�[0m (OUT) hailctl config set query/backend spark�[0m
2025-01-08T18:46:51.4896881Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT) Traceback (most recent call last):�[0m
2025-01-08T18:46:51.4898272Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)   File "/opt/conda/conda-bld/hail_1736361598998/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin/hailctl", line 7, in <module>�[0m
2025-01-08T18:46:51.4899565Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)     from hailtop.hailctl.__main__ import main�[0m
2025-01-08T18:46:51.4901348Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)   File "/opt/conda/conda-bld/hail_1736361598998/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.10/site-packages/hailtop/hailctl/__main__.py", line 1, in <module>�[0m
2025-01-08T18:46:51.4902722Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)     import typer�[0m
2025-01-08T18:46:51.4903155Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT) ModuleNotFoundError: No module named 'typer'�[0m
2025-01-08T18:46:51.4903656Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT) make: *** [Makefile:396: install] Error 1�[0m
2025-01-08T18:46:51.4904121Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT) Traceback (most recent call last):�[0m
2025-01-08T18:46:51.4904768Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)   File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2558, in build�[0m
2025-01-08T18:46:51.4905351Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)     utils.check_call_env(�[0m
2025-01-08T18:46:51.4905997Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)   File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 404, in check_call_env�[0m
2025-01-08T18:46:51.4906741Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)     return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)�[0m
2025-01-08T18:46:51.4907559Z 18:46:51 �[32mBIOCONDA INFO�[0m (OUT)   File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 380, in _func_defaulting_env_to_os_environ�[0m

@mjsteinbaugh
Copy link
Member Author

This is a beast to manage, not sure how to fix the typer issue

Steinbaugh, Michael added 2 commits January 8, 2025 15:20
@mjsteinbaugh
Copy link
Member Author

Hitting this error when attempting to build from tarball instead of git repo directly:

2025-01-08T20:36:34.8412318Z 20:36:34 �[32mBIOCONDA INFO�[0m (OUT) $SRC_DIR/hail $SRC_DIR�[0m
2025-01-08T20:36:34.8412842Z 20:36:34 �[32mBIOCONDA INFO�[0m (OUT) fatal: not a git repository (or any of the parent directories): .git�[0m
2025-01-08T20:36:34.8413484Z 20:36:34 �[32mBIOCONDA INFO�[0m (OUT) version.mk:3: *** "git rev-parse HEAD" failed to produce output.  Stop.�[0m
2025-01-08T20:36:34.8414014Z 20:36:34 �[32mBIOCONDA INFO�[0m (OUT) Traceback (most recent call last):�[0m

@aliciaaevans
Copy link
Contributor

I wonder if it would work to use PyPI as the source or do you think it would run into the same issue? https://bioconda.github.io/contributor/guidelines.html#python

@mjsteinbaugh
Copy link
Member Author

@aliciaaevans Great idea, I'll try that and see if just building the Python package works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants