Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ghref for CLI to @bigcommerce/catalyst-core@latest #1859

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Jan 7, 2025

What/Why?

Set default ghref to use the latest tag, so that CLI users will not be exposed to canary code by default.

Testing

Ran create with no args:
image
image

Ran create with --reset-main:
image
image

Ran create with a --gh-ref and --reset-main:
image
image

@bookernath bookernath requested a review from a team as a code owner January 7, 2025 01:20
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 3:33am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 3:33am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 7, 2025 3:33am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 3:33am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 3:33am

@bookernath bookernath force-pushed the default-ghref-by-tag branch from 84e440c to 209a989 Compare January 7, 2025 01:22
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 037af23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bookernath bookernath added this pull request to the merge queue Jan 7, 2025
Merged via the queue into canary with commit 62d178e Jan 7, 2025
13 of 14 checks passed
@bookernath bookernath deleted the default-ghref-by-tag branch January 7, 2025 03:39
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-9q1mmh5o8-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 74
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants