fix(m4): Disable lttng when --with-lttng not specified during configuration #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
previously approved these changes
Jan 7, 2025
mozarhua
force-pushed
the
disable-lttng-by-default
branch
from
e08c91d to
1814df0
Compare
rauteric
previously approved these changes
Jan 7, 2025
bwbarrett
requested changes
Jan 7, 2025
Disable lttng when --with-lttng not specified during configuration. Signed-off-by: Mozar Huang <[email protected]>
mozarhua
force-pushed
the
disable-lttng-by-default
branch
from
1814df0 to
4f31c38
Compare
bwbarrett
approved these changes
Jan 8, 2025
rauteric
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable LTTng by default unless explicitly enabled during configuration
Unit tested configure with:
--with-lttng=noor without--with-lttng: HAVE_LIBLTTNG_UST is defined as 0.--with-lttng=yes: HAVE_LIBLTTNG_UST is defined as 1. The libnccl-net.so links to the detected lttng ust library.--with-lttng=<path>: HAVE_LIBLTTNG_UST` is defined as 1. The libnccl-net.so links to the specified lttng ust library.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.