.ci/aws: Skip default SCM checkout #758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhenye-Na
force-pushed
the
skip-default-scm-checkout
branch
from
b0411e1 to
41c404a
Compare
Zhenye-Na
changed the title
rajachan
previously approved these changes
Jan 6, 2025
| @@ -134,6 +134,7 @@ pipeline { | |||
| options { | |||
| buildDiscarder(logRotator(daysToKeepStr: "90")) | |||
| timeout(time: 24, unit: 'HOURS') | |||
| skipDefaultCheckout() | |||
There was a problem hiding this comment.
Commit message and change doesn't align? Where do we define the next step to be workspace cleanup?
There was a problem hiding this comment.
Where do we define the next step to be workspace cleanup?
The workspace clean up was removed in commit a8009b8. Also, in this commit, we removed
stage("Checkout SCM repo") {
steps {
checkout scm
}
}
Based on Seth's explanation "checkoutSCMRepo pulls down aws-ofi-nccl to the fargate agent, which is a waste of time because we only need it on the cluster."
However, even though we explicitly removed the step above. Jenkins itself contains a default SCM checkout step, with this line of change, this step should be removed completely for us.
Signed-off-by: Nathan Na <[email protected]>
Zhenye-Na
force-pushed
the
skip-default-scm-checkout
branch
from
41c404a to
d99e4f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Jenkins has a default step to checkout the code base from SCM, which took around 30s. But we defined next step to be workspace cleanup.
Description of changes:
This change is to skip the default step and only checkout the code base as we defined in the pipeline step
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.