sendrecv: Include copy of max_tag in endpoint #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
approved these changes
Dec 6, 2024
The sendrecv code includes a number of places that were referencing the device object solely to get the max_tag value. Simplify things and reduce cache usage by including a copy of max_tag in the endpoint structure. Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
cleanup/less-device-referencing
branch
from
4ae597b to
0524bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sendrecv code includes a number of places that were referencing the device object solely to get the max_tag value. Simplify things and reduce cache usage by including a copy of max_tag in the endpoint structure.
This is general cleanup, but part of a patch series working towards removing a bunch of locking from the code to a high level lock, but cleanups like this also help minimize the random cache lines we're loading.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.