Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples for ec2 #9191

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Examples for ec2 #9191

merged 1 commit into from
Jan 7, 2025

Conversation

elysahall
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall added documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member. labels Jan 7, 2025
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, will wait for CI to pass before approving and porting to the v2 branch.

@github-actions github-actions bot mentioned this pull request Jan 7, 2025
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (02bb319) to head (0550dd4).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #9191      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16978   16984       +6     
==========================================
  Hits            14      14              
- Misses       16964   16970       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdaily
Copy link
Member

kdaily commented Jan 7, 2025

LGTM. Opened v2 PR #9192.

@kdaily kdaily merged commit b788496 into aws:develop Jan 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants