chore: Clean AREnableNewSearchModal ff related code #11347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
reviewed
Jan 8, 2025
| @@ -241,12 +241,6 @@ export const features = { | |||
| showInDevMenu: true, | |||
| echoFlagKey: "AREnablePaymentFailureBanner", | |||
| }, | |||
| AREnableNewSearchModal: { | |||
There was a problem hiding this comment.
Don't forget to deprecate the feature flag in echo like so:artsy/echo#744
There was a problem hiding this comment.
Just out of curiosity, what's the idea behind adding comments about the removal in Echo instead of looking into Eigen's features.ts file or history?
There was a problem hiding this comment.
in echo we have a killswitch for app versions, once in a while we go through the stale feature flags that have been removed and we clean them out by removing them
There was a problem hiding this comment.
Pretty cool! And the timestamp in the comment makes a lot of sense then. Thanks for the explanation 🙏
olerichter00
deleted the
olerichter00/ONYX-1367/clean-arenablenewsearchmodal-ff-related-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1367
Description
Clean AREnableNewSearchModal ff related code.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.