feat(EMI-2237): Update iOS in-app push notification style #11334
+93
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSltun
requested review from
MounirDhahri,
gkartalis,
brainbicycle and
a team
gkartalis
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Tricky pr but awesome work! I would like a second pair of eyes when @brainbicycle is back but feel free to merge till then and we further test it out on next mobile QA session.
Please remember to add a test case with how to test steps 🙏
MrSltun
commented
Jan 8, 2025
| [mock verify]; | ||
| [mock stopMocking]; | ||
|
|
||
| [mockEmissionSharedInstance verify]; | ||
| }); |
There was a problem hiding this comment.
This test was removed since we won't use the ARNotificationView class to show the notification anymore
MrSltun
deleted the
mrsltun/EMI-2237/update-ios-in-app-notification-style
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves EMI-2237
Description
This PR updates the native iOS in-app notification view to the default notification style when the app is in the foreground
Videos
ios-foreground-notification-before-low.mp4
ios-foreground-notification-after-low.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.