fix(export): charts csv export in dashboards #31649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelCbd
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
dosubot
bot
added
dashboard:export
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this rooster.
\\
(o>
\\_//)
\_/_)
_|_Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/theme.ts | ✅ |
| superset/init.py | ✅ |
| superset-frontend/src/dashboard/components/gridComponents/Chart.jsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
|
looks like your PR has unrelated Ubuntu bumps, mind rebasing/cleaning it up? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31649 +/- ##
===========================================
+ Coverage 60.48% 70.95% +10.46%
===========================================
Files 1931 2003 +72
Lines 76236 81019 +4783
Branches 8568 9216 +648
===========================================
+ Hits 46114 57485 +11371
+ Misses 28017 21293 -6724
- Partials 2105 2241 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mistercrunch
changed the title
|
PR rejected, I closed it and did a clean one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When doing a CSV export of a chart in a dashboard, it's always a fullCSV, instead of a "standard" export, even if parameter ALLOW_FULL_CSV_EXPORT is False
BEFORE/AFTER SCREENSHOTS
Before: ROW_LIMIT set to 100, export is over 100000 lines
After: Before: ROW_LIMIT set to 100, export is 100 lines (101 here because of the header)
TESTING INSTRUCTIONS
number of lines is over the limit
ADDITIONAL INFORMATION