Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49273][Connect][SQL] Origin support for Spark Connect Scala client #49373

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

xupefei
Copy link
Contributor

@xupefei xupefei commented Jan 6, 2025

What changes were proposed in this pull request?

This PR adds support for Origin to the Scala client of Spark Connect.

The approach is to send the client Origin instance over the wire to the Server, which will reconstruct the instance and attach it to the expression during transformation.

One Origin message can contain only one of PythonOrigin and JvmOrigin. The former is filled by the Python client (#46789) and the latter by the Scala client (this PR).

Why are the changes needed?

Close the gap between Classic & Connect.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

New tests.

Was this patch authored or co-authored using generative AI tooling?

Yes, to generate protobuf messages.

# Conflicts:
#	connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/KeyValueGroupedDatasetE2ETestSuite.scala
@github-actions github-actions bot added the PYTHON label Jan 7, 2025
@xupefei xupefei changed the title [SPARK-49273] Origin support for Spark Connect Scala client [SPARK-49273][Connect][SQL] Origin support for Spark Connect Scala client Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant