Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Implement list with deleted and versions for cos #5514

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Jan 7, 2025

Which issue does this PR close?

Part of #5496

Rationale for this change

Implement the cos in RFC we need.

What changes are included in this PR?

Implement list with deleted for cos services
Implement versions for cos services

Are there any user-facing changes?

Users can now list deleted files and user versions from cos services.

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #5514 will improve performances by 18.88%

Comparing cos-list-with-deleted (b00769f) with main (1c287eb)

Summary

⚡ 4 improvements
✅ 69 untouched benchmarks

Benchmarks breakdown

Benchmark main cos-list-with-deleted Change
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%

@hoslo hoslo force-pushed the cos-list-with-deleted branch from 3693133 to afdd157 Compare January 7, 2025 03:02
@Xuanwo
Copy link
Member

Xuanwo commented Jan 7, 2025

It's better to fix #5507 before adding more services support.

@hoslo hoslo force-pushed the cos-list-with-deleted branch from afdd157 to 3b184e8 Compare January 8, 2025 02:39
@Xuanwo Xuanwo changed the title feat: cos list-with-deleted feat(core): Implement list with deleted and versions for cos Jan 8, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Jan 8, 2025

The versioning tests are not covered because there is no bucket set up for COS. I'll look into it.

@hoslo hoslo force-pushed the cos-list-with-deleted branch from 3b184e8 to 822f81f Compare January 8, 2025 02:58
@Xuanwo
Copy link
Member

Xuanwo commented Jan 8, 2025

cos doesn't support write with if not exists while versioning has been enabled.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hoslo, for working on this. I have fixed several issues that were breaking the CI. Everything else looks good to me!

@Xuanwo Xuanwo merged commit dc32a6a into main Jan 8, 2025
91 checks passed
@Xuanwo Xuanwo deleted the cos-list-with-deleted branch January 8, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants