-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Implement list with deleted and versions for cos #5514
Conversation
CodSpeed Performance ReportMerging #5514 will improve performances by 18.88%Comparing Summary
Benchmarks breakdown
|
3693133
to
afdd157
Compare
It's better to fix #5507 before adding more services support. |
afdd157
to
3b184e8
Compare
The versioning tests are not covered because there is no bucket set up for COS. I'll look into it. |
3b184e8
to
822f81f
Compare
cos doesn't support |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
…ed' into cos-list-with-deleted
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @hoslo, for working on this. I have fixed several issues that were breaking the CI. Everything else looks good to me!
Which issue does this PR close?
Part of #5496
Rationale for this change
Implement the cos in RFC we need.
What changes are included in this PR?
Implement list with deleted for cos services
Implement versions for cos services
Are there any user-facing changes?
Users can now list deleted files and user versions from cos services.