KAFKA-18211: Override class loaders for class graph scanning in connect. #18403
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharris1727
reviewed
Jan 6, 2025
|
Yes, made some updates and added a test for this scenario. On a side not, may I get auto approval to run the test suite on my PRs, will help with validating the Multiversion PRs. |
|
Sorry about that, clicking the approval button approves a single run and the label approves multiple runs. TIL |
gharris1727
reviewed
Jan 7, 2025
| @MethodSource("parameters") | ||
| public void testClasspathPluginIsAlsoLoadedInIsolation(PluginScanner scanner) { | ||
| // json converter is part of the classpath by default | ||
| String jsonConverterLocation = JsonConverter.class.getProtectionDomain().getCodeSource().getLocation().getPath(); |
There was a problem hiding this comment.
This feels very brittle to me.
Rather than using a real class, can this use a TestPlugin with a similar name to a classpath plugin?
Or the last time we needed to set up a "classpath" plugin, it was by injecting a new loader in the hierarchy in PluginsTest#assertClassLoaderReadsVersionFromResource.
Comment on lines
+85
to
+93
| // In addition, we need to explicitly specify the full classloader order, as classgraph only scans the classes available | ||
| // in the classloaders and not the entire parent chain. Due to this reason if a plugin is extending a class present | ||
| // in classpath/application it will not be able to find the parent class unless we explicitly specify the classloader order. | ||
| List<ClassLoader> classLoaderOrder = new ArrayList<>(); | ||
| ClassLoader cl = source.loader(); | ||
| while (cl != null) { | ||
| classLoaderOrder.add(cl); | ||
| cl = cl.getParent(); | ||
| } |
There was a problem hiding this comment.
Is this true? What is the ignoreParentClassLoaders method doing then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue highlighted in https://issues.apache.org/jira/browse/KAFKA-18211
Committer Checklist (excluded from commit message)