branch-2.1: [opt](cache) enhance cache key computation by removing comments and trimming SQL input #46099 #46472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
…rimming SQL input (#46099) - Currently, the SQL cache system in Doris may miss cache hits due to semantically identical queries being treated as different because of: - Extra whitespace characters in the SQL query - SQL comments that don't affect the query execution - For example, these queries are semantically identical but would generate different cache keys: ```sql SELECT * FROM table; -- Same query with comments and extra spaces /* Comment */ SELECT * FROM table ; ``` - This PR improves the SQL cache hit rate by: - Trimming whitespace from SQL queries - Removing SQL comments before calculating the cache key MD5 - This ensures that queries that are semantically identical but differ only in whitespace or comments will now hit the same cache entry, improving cache efficiency and reducing unnecessary query executions
yiguolei
force-pushed
the
auto-pick-46099-branch-2.1
branch
from
dd98532 to
009683e
Compare
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #46099