-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) infer in-predicate from or-predicate #46468
Open
englefly
wants to merge
3
commits into
apache:master
Choose a base branch
from
englefly:orToInV3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+236
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32462 ms
|
TPC-DS: Total hot run time: 190911 ms
|
ClickBench: Total hot run time: 31.09 s
|
run buildall |
TPC-H: Total hot run time: 32809 ms
|
TPC-DS: Total hot run time: 197193 ms
|
ClickBench: Total hot run time: 31.16 s
|
run p0 |
starocean999
approved these changes
Jan 8, 2025
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 8, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
previous verion has follow drawbacks
in order to solve above issues, we implemented a new version
first, it is a plan node level rule to avoid to be applied to the same expression repeatedly
second, we define replace mode and extract mode. if in replace mode, the original expression should be equivalent to the inferred in-pred, which is used for all plan node's expressions except filter.
for example, orig = "(a=1 and b=1) or (a=2 and c=2)" is equivalent to "a in (1, 2) and (a=1 and b=1) or (a=2 and c=2)".
orig is a filter condition, "a in (1, 2)" can be pushed down to storage layer, and this infer is useful. But if this is orig is an other join condition, this inferrence is useless. So in extract mode, "a in (1, 2)" is inferred, but in replace mode, it is not.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)