-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) cache legacy literal for reducing sort literals time #46350
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
1 similar comment
run buildall |
could we avoid use legacy literal to do sort? |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should impl compareTo in Nereids' Literal self
e332c82
to
f357b86
Compare
#46482 compare literal don't call toLegacyLiteral |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
as #45181 mention, when sorting literals, toLegacyLiteral may cost a lot of time, so we cache the legacy time to reduce time.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)