Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](nereids) cache legacy literal for reducing sort literals time #46350

Closed
wants to merge 1 commit into from

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Jan 3, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

as #45181 mention, when sorting literals, toLegacyLiteral may cost a lot of time, so we cache the legacy time to reduce time.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Collaborator Author

yujun777 commented Jan 3, 2025

run buildall

1 similar comment
@yujun777
Copy link
Collaborator Author

yujun777 commented Jan 3, 2025

run buildall

924060929
924060929 previously approved these changes Jan 3, 2025
@morrySnow
Copy link
Contributor

could we avoid use legacy literal to do sort?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should impl compareTo in Nereids' Literal self

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 6, 2025
@yujun777 yujun777 force-pushed the opt-to-legacy-literal branch from e332c82 to f357b86 Compare January 6, 2025 02:47
@yujun777
Copy link
Collaborator Author

yujun777 commented Jan 6, 2025

#46482 compare literal don't call toLegacyLiteral

@yujun777 yujun777 closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants