[Improvement-16887][Dependent Task] Dependent task improvement #16910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
added
UI
SbloodyS
requested review from
EricGao888,
songjianet,
caishunfeng,
Gallardot and
ruanwenjun
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...er-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceDependentResult.java
Fixed
Show fixed
Hide fixed
...ache/dolphinscheduler/server/master/engine/executor/plugin/dependent/DependentLogicTask.java
Fixed
Show fixed
Hide fixed
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ruanwenjun
reviewed
Dec 23, 2024
...he/dolphinscheduler/server/master/engine/executor/plugin/dependent/DependentTaskTracker.java
Outdated
Show resolved
Hide resolved
...ache/dolphinscheduler/server/master/engine/executor/plugin/dependent/DependentLogicTask.java
Dismissed
Show dismissed
Hide dismissed
ruanwenjun
reviewed
Dec 25, 2024
...nscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceContext.java
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ContextType.java
Outdated
Show resolved
Hide resolved
...er-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceDependentResult.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceDependentResultContext.java
Outdated
Show resolved
Hide resolved
| import lombok.EqualsAndHashCode; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
...r-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceDependentDetails.java
Fixed
Show fixed
Hide fixed
ruanwenjun
reviewed
Dec 31, 2024
...rc/main/java/org/apache/dolphinscheduler/dao/repository/impl/TaskInstanceContextDaoImpl.java
Show resolved
Hide resolved
...nscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstanceContext.java
Show resolved
Hide resolved
...rc/main/java/org/apache/dolphinscheduler/dao/repository/impl/TaskInstanceContextDaoImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/dolphinscheduler/dao/repository/impl/TaskInstanceContextDaoImpl.java
Show resolved
Hide resolved
ruanwenjun
reviewed
Dec 31, 2024
.../src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowInstanceServiceImpl.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
Dec 31, 2024
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ContextType.java
Outdated
Show resolved
Hide resolved
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ruanwenjun
previously approved these changes
Jan 1, 2025
caishunfeng
reviewed
Jan 2, 2025
...uler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceContextMapper.java
Show resolved
Hide resolved
...uler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceContextMapper.java
Show resolved
Hide resolved
...ler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceContextDao.java
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql
Outdated
Show resolved
Hide resolved
caishunfeng
reviewed
Jan 2, 2025
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql
Outdated
Show resolved
Hide resolved
|
SbloodyS
changed the title
ruanwenjun
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16887
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md