-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Distroless] Reorganize and refactor Distroless build and test details #33494
base: master
Are you sure you want to change the base?
Conversation
e3e3782
to
e42b922
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33494 +/- ##
=========================================
Coverage 57.42% 57.42%
Complexity 1475 1475
=========================================
Files 980 980
Lines 155081 155081
Branches 1076 1076
=========================================
Hits 89063 89063
Misses 63819 63819
Partials 2199 2199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - I think this is a good approach. I had one piece of (very minor) feedback, otherwise this LGTM
|
||
description = "Apache Beam :: SDKs :: Python :: Container :: Distroless" | ||
int min_python_version=9 | ||
int max_python_version=12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment here (and in the sdks/python/container/build.gradle
file same spot saying that these need to be kept in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
This PR addresses #32817 and addresses #32818 reorganizing and refactoring the mechanism to build and test distroless variants.
Please ignore any of the GitHub workflows that include 'Distroless' in its name as these are expected to fail, such as
beam_PostCommit_Java_ValidatesDistrolessContainer_Dataflow
.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.