Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distroless] Reorganize and refactor Distroless build and test details #33494

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jan 4, 2025

This PR addresses #32817 and addresses #32818 reorganizing and refactoring the mechanism to build and test distroless variants.

Please ignore any of the GitHub workflows that include 'Distroless' in its name as these are expected to fail, such as beam_PostCommit_Java_ValidatesDistrolessContainer_Dataflow.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.42%. Comparing base (4a32482) to head (00319f8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33494   +/-   ##
=========================================
  Coverage     57.42%   57.42%           
  Complexity     1475     1475           
=========================================
  Files           980      980           
  Lines        155081   155081           
  Branches       1076     1076           
=========================================
  Hits          89063    89063           
  Misses        63819    63819           
  Partials       2199     2199           
Flag Coverage Δ
python 81.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damondouglas damondouglas marked this pull request as ready for review January 6, 2025 17:03
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @Abacn for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - I think this is a good approach. I had one piece of (very minor) feedback, otherwise this LGTM


description = "Apache Beam :: SDKs :: Python :: Container :: Distroless"
int min_python_version=9
int max_python_version=12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here (and in the sdks/python/container/build.gradle file same spot saying that these need to be kept in sync?

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants