Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable supression of dead servers in Monitor by resource group #5226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dlmarion
Copy link
Contributor

@dlmarion dlmarion commented Jan 6, 2025

Closes #5162

@dlmarion dlmarion added this to the 4.0.0 milestone Jan 6, 2025
@dlmarion dlmarion requested a review from ddanielr January 6, 2025 23:02
@dlmarion dlmarion self-assigned this Jan 6, 2025
Copy link
Member

@DomGarguilo DomGarguilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I cant tell. I didn't test these changes though.

"The Monitor displays information about servers that it believes have died recently."
+ " This property accepts a comma separated list of resource group names. If"
+ " the dead servers resource group matches a resource group in this list,"
+ " then it will be suppressed.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ " then it will be suppressed.",
+ " then it will be suppressed from the dead servers list in the monitor.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support differentiating between static and dynamic resource groups
2 participants