Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tserver lock entries per group #5199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove tserver lock entries per group #5199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions assemble/bin/accumulo-cluster
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,12 @@ function control_services() {

local count
local hosts
local zap_group
if [[ $ARG_ALL == 1 || $ARG_TSERVER == 1 ]]; then
tserver_groups=$TSERVER_GROUPS
if [[ -n $ARG_TSERVER_GROUP ]]; then
tserver_groups=$ARG_TSERVER_GROUP
zap_group=$ARG_TSERVER_GROUP
fi
for group in $tserver_groups; do
echo "${cmd}ing tablet servers for group $group"
Expand Down Expand Up @@ -467,10 +469,17 @@ function control_services() {
done
fi

if [[ $ARG_LOCAL == 0 && $ARG_ALL == 1 && ($operation == "stop" || $operation == "kill") ]]; then
if ! isDebug; then
echo "Cleaning all server entries in ZooKeeper"
$accumulo_cmd org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers
if [[ $ARG_LOCAL == 0 && ($operation == "stop" || $operation == "kill") ]]; then
if [[ $ARG_TSERVER == 1 ]]; then
if ! isDebug; then
echo "Cleaning all tserver entries in ZooKeeper"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Cleaning all tserver entries in ZooKeeper"
echo "Cleaning all $(yellow tserver) entries in ZooKeeper"

$accumulo_cmd org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group"
dlmarion marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be quoted because it can contain spaces in the path.

Suggested change
$accumulo_cmd org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group"
"$accumulo_cmd" org.apache.accumulo.server.util.ZooZap -tservers -group "$zap_group"

fi
elif [[ $ARG_ALL == 1 ]]; then
if ! isDebug; then
echo "Cleaning all server entries in ZooKeeper"
$accumulo_cmd org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$accumulo_cmd org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers
"$accumulo_cmd" org.apache.accumulo.server.util.ZooZap -manager -tservers -compactors -sservers

fi
fi
fi

Expand Down
Loading