Use multiple YAML documents for inventory plugin examples #9551
+50
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
check-before-release
ansibullbot
added
cloud
docs
inventory
tremble
approved these changes
Jan 8, 2025
russoz
reviewed
Jan 8, 2025
Co-authored-by: Alexei Znamensky <[email protected]>
felixfontein
removed
the
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9559 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Use multiple YAML documents for inventory plugin examples. * Add ignore.txt entries. * Delete no longer needed ignore.txt files. * Fix typo. Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 3f7ea60)
felixfontein
added a commit
that referenced
this pull request
Jan 8, 2025
…or inventory plugin examples (#9559) Use multiple YAML documents for inventory plugin examples (#9551) * Use multiple YAML documents for inventory plugin examples. * Add ignore.txt entries. * Delete no longer needed ignore.txt files. * Fix typo. Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 3f7ea60) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I thought this still doesn't work, but apparently @tremble fixed it more than a year ago in ansible/ansible@5346009! Thanks a lot for that :)
This likely won't pass CI since ansible-core 2.16 and before won't accept this, I'll add ignore.txt entries in a follow-up commit once I know what exactly fails.
ISSUE TYPE
COMPONENT NAME
inventory plugins