o*: style adjustments #9526
Open
o*: style adjustments #9526
+193
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
check-before-release
felixfontein
reviewed
Jan 6, 2025
russoz
commented
Jan 7, 2025
plugins/modules/one_vm.py
Outdated
| for details. | ||
| - Wait for the instance to reach its desired state before returning. Keep in mind if you are waiting for instance to | ||
| be in running state it does not mean that you will be able to SSH on that machine only that boot process have started | ||
| on that instance. See the example using the M(ansible.builtin.wait_for_instance) for details. |
There was a problem hiding this comment.
Suggested change
| on that instance. See the example using the M(ansible.builtin.wait_for_instance) for details. | |
| on that instance. See the example using the M(ansible.builtin.wait_for) for details. |
There was a problem hiding this comment.
There is no example using wait_for. There is only one using wait_for_instance. So I guess the example needs to be fixed as well.
There was a problem hiding this comment.
I believe you mean this one:
- name: Wait for SSH to come up
ansible.builtin.wait_for_connection:
delegate_to: '{{ vm.instances[0].networks[0].ip }}'Which should be, in theory, if not in practice:
- name: Wait for SSH to come up
ansible.builtin.wait_for:
port: 22 # it says SSH ^
host: '{{ vm.instances[0].networks[0].ip }}' # ??? not sureThere was a problem hiding this comment.
Yep, I meant that one.
There was a problem hiding this comment.
The right form is probably:
- name: Wait for SSH to come up
ansible.builtin.wait_for:
delegate_to: '{{ vm.instances[0].networks[0].ip }}'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Second round of doc adjustments. Output width has been slightly reduced in andebox, and a couple of other style improvements have been added (like replacing id with ID)
ISSUE TYPE
COMPONENT NAME
plugins/modules/ocapi_command.py
plugins/modules/ocapi_info.py
plugins/modules/oci_vcn.py
plugins/modules/office_365_connector_card.py
plugins/modules/ohai.py
plugins/modules/one_host.py
plugins/modules/one_image.py
plugins/modules/one_image_info.py
plugins/modules/one_service.py
plugins/modules/one_template.py
plugins/modules/one_vm.py
plugins/modules/one_vnet.py
plugins/modules/oneandone_firewall_policy.py
plugins/modules/oneandone_load_balancer.py
plugins/modules/oneandone_monitoring_policy.py
plugins/modules/oneandone_server.py
plugins/modules/onepassword_info.py
plugins/modules/oneview_datacenter_info.py
plugins/modules/oneview_enclosure_info.py
plugins/modules/oneview_ethernet_network_info.py
plugins/modules/oneview_logical_interconnect_group.py
plugins/modules/oneview_network_set_info.py
plugins/modules/oneview_san_manager.py
plugins/modules/open_iscsi.py
plugins/modules/openbsd_pkg.py
plugins/modules/opendj_backendprop.py
plugins/modules/openwrt_init.py
plugins/modules/opkg.py
plugins/modules/osx_defaults.py
plugins/modules/ovh_ip_failover.py
plugins/modules/ovh_ip_loadbalancing_backend.py