Fixes and improvements #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures don't look like they were introduced by this PR |
|
Looks good, thanks for tracking this down, must have been a nightmare. |
|
Yeah, it was tedious and unpleasant in a lot of ways. Maybe the worst part was learning about how Linux IO works on a low level and how fundamentally broken it actually is. About the second commit with the error messages, it is far from complete (it mainly contains a few sprinkled annotations that were required for me to track down the bug). I suggest merging it as-is, and strongly encouraging adding more |
This comment was marked as resolved.
This comment was marked as resolved.
|
friendly ping |
|
@andrewchambers Any chance you could take a look another look at this? |
Partially fixes andrewchambers#367
Although the examples already disambiguate this, this hopefully makes it more clear that the command is not a single argument which may need to be escaped, but a list of arguments which will be executred
The letter conflicts with --exclude, which would be much better suited for a shorthand. Unlike --exclude, --exec is only used up to once, less often, and is shorter. I didn't directly add -e back as a shorthand for --exclude, as I'm not 100% sure yet if we'd want that.
Closes andrewchambers#389. Also implements a duplicates check, therefore fixes andrewchambers#396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378