Update README.md with ownership info #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudoyim
requested review from
markan,
Callek,
cbouss,
marcoesters and
jmlphd
Callek
approved these changes
Oct 7, 2024
| [anaconda-pkg-base](https://hub.docker.com/r/continuumio/anaconda-pkg-base/tags?page=1&ordering=last_updated) | Package Automation Team | Container *without* a bootstrapped Anaconda installation with GCC | [](https://hub.docker.com/r/continuumio/anaconda-pkg-base) | [](https://hub.docker.com/r/continuumio/anaconda-pkg-base) | [](https://hub.docker.com/r/continuumio/anaconda-pkg-base) | ||
|
|
||
| **Note regarding owners**: | ||
| - The `anaconda-pkg-*` images are owned by the Package Automation Team, but decisions about the contents of these Dockerfiles must be reviewed and approved by the Package Build Core Team. |
There was a problem hiding this comment.
Suggested change
| - The `anaconda-pkg-*` images are owned by the Package Automation Team, but decisions about the contents of these Dockerfiles must be reviewed and approved by the Package Build Core Team. | |
| - The `anaconda-pkg-*` images are owned by the Package Automation Team, but decisions about the contents of these Dockerfiles must be reviewed and approved by the Package Build Core Team, alternatively the Package Build Core Team may choose to make modifications themselves with final approval by the Package Automation Team. |
(Or some alternative wording to reflect ~ the same)
|
Can you explain why the internal ownership within Anaconda is important to document for this (public) repository? |
|
agreeing to what @marcoesters says. This is a public repo, lets not document it like that. A CODEOWNERS file (referencing groups) for specific folders could be of help (as that also auto assigns and notifies the group for PRs)... AND/OR splitting the repo and moving out the package build images to AnacondaRecipes org where they belong to (for better owner clarity) would be of help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.