Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update git-sync to v4.4.0 #901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lostkamp
Copy link

What issues does your PR fix?

What does your PR do?

Updates git-sync image to v4.4.0 and adapts the env variables accordingly.

The changes are backwards-compatible with the exception that the --branch and --rev flags have been merged to the new --ref flag. This implies that .Values.dags.gitSync.branch and .Values.dags.gitSync.revision should also be merged. I have implemented it like that following this table.

In the docs examples I have used the branch name as the revision, because I thought people would most likely want to specify a branch instead of "HEAD" or so and they might be confused if they don't see a way to do that.

The other option would be to not merge the values and rely on:

For backwards compatibility, git-sync will still accept the old flags and try to set --ref from them.

Checklist

For all Pull Requests

For releasing ONLY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant