AG-13798 Fix 'wheel' zoom events in Safari #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be because the `passive` defaults in Safari is different to other browsers. Regardless, we're adding `'wheel'` event listeners to the .ag-charts-series-area element which has the CSS value `pointer-events: none`. This is sort of asking for trouble. Making the .ag-charts-series-area have `pointer-event: auto` works on all browsers (Safari, Firefox, Chrome), although we need to set the .ag-charts-series-area's tabindex to -1 and focus on the .ag-charts-swapchain child when the series area is clicked on.
|
Snapshots automatically updated, please review before merge: diff |
jacobp100
approved these changes
Jan 6, 2025
| @@ -37,14 +37,14 @@ | |||
|
|
|||
| .ag-charts-series-area { | |||
| outline: none; | |||
| pointer-events: none; | |||
| pointer-events: auto; | |||
There was a problem hiding this comment.
I don’t feel too strongly here, but currently we only do this if we’re overriding ‘none’ from a parent element
There was a problem hiding this comment.
AFAIK it's necessary because the immediate parent has pointer-events: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13798
This might be because the
passivedefaults in Safari is different to other browsers. Regardless, we're adding'wheel'event listeners to the .ag-charts-series-area element which has the CSS valuepointer-events: none. This is sort of asking for trouble.Making the .ag-charts-series-area have
pointer-event: autoworks on all browsers (Safari, Firefox, Chrome), although we need to set the .ag-charts-series-area's tabindex to -1 and focus on the .ag-charts-swapchain child when the series area is clicked on.