Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] action does fail with valid licenses like Unicode-3.0 #854

Open
ailox opened this issue Dec 6, 2024 · 1 comment · May be fixed by #855
Open

[BUG] action does fail with valid licenses like Unicode-3.0 #854

ailox opened this issue Dec 6, 2024 · 1 comment · May be fixed by #855
Labels
bug Something isn't working

Comments

@ailox
Copy link

ailox commented Dec 6, 2024

Describe the bug
This action fails when adding a license like Unicode-3.0 into the allowed_licenses section.

To Reproduce
Steps to reproduce the behavior:

  1. Add the dependency-review-action to a project
  2. allow-licenses: "Unicode-3.0"
  3. Trigger
  4. See error: "Error: Invalid license(s) in allow-licenses: Unicode-3.0"

Expected behavior
License is allowed and can be used.

Action version
4.5.0 (latest as of today)

@ailox ailox added the bug Something isn't working label Dec 6, 2024
@ailox ailox linked a pull request Dec 6, 2024 that will close this issue
@ailox
Copy link
Author

ailox commented Dec 6, 2024

I used this primitive test to validate the solution:

import {expect, test} from '@jest/globals'
import * as spdx from '../src/spdx'

test('Unicode', async () => {
  expect(spdx.isValid('Unicode-3.0')).toEqual(true)
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant