Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chia-datalayer #673

Merged
merged 199 commits into from
Dec 18, 2024
Merged

chia-datalayer #673

merged 199 commits into from
Dec 18, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Aug 21, 2024 •
edited
Loading

Maybe this actually grows into something. For now it is an opportunity to practice Rust within an existing Chia project.

it grew...

partial testing of swappability with the python implementation is tested at Chia-Network/chia-blockchain#18716.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12266475154

Details

  • 1145 of 1269 (90.23%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 84.486%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-datalayer/src/merkle/dot.rs 84 95 88.42%
crates/chia-datalayer/src/merkle.rs 1058 1171 90.35%
Totals Coverage Status
Change from base Build 12266368133: 0.5%
Covered Lines: 14170
Relevant Lines: 16772
💛 - Coveralls

Rigidity
Rigidity reviewed Aug 21, 2024
View reviewed changes
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
altendky
altendky commented Aug 22, 2024
View reviewed changes
Copy link
Contributor Author

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
crates/chia-datalayer/src/lib.rs Outdated Show resolved Hide resolved
@altendky altendky marked this pull request as ready for review December 10, 2024 23:19
@altendky
Copy link
Contributor Author

actions/dependency-review-action#854

@altendky altendky requested a review from arvidn December 11, 2024 13:07
@altendky altendky requested a review from arvidn December 11, 2024 14:40
@altendky altendky changed the base branch from main to long_lived/initial_datalayer December 12, 2024 19:28
arvidn
arvidn previously approved these changes Dec 18, 2024
View reviewed changes
@altendky altendky merged commit 6e9c7c4 into long_lived/initial_datalayer Dec 18, 2024
51 of 52 checks passed
@altendky altendky deleted the merkle_blob branch December 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@Rigidity Rigidity Rigidity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @arvidn @Rigidity