Passed arguments everywhere to buffer.readUInt32BE() to avoid some errors #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors webpack/node-libs-browser#93 Webpack 4 now is a stable version. It uses node-libs for Buffer polyfill that is not completely compatible with the nodejs implemintation. In node-libs a lot of optional arguments are required, so we get an offset error in the browser calling buffer.readUInt32BE without an argument.
|
Published with 0.1.19 👍 |
|
Big thanks!
…On Fri, Sep 25, 2020 at 10:56 PM Jan Metzger ***@***.***> wrote:
Published with 0.1.19 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#81 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRCD4BBCGWRQXI2YDEPQTSHTYX5ANCNFSM4RUDYXEQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack/node-libs-browser#93
Webpack 4 now is a stable version. It uses node-libs for Buffer polyfill that is not completely compatible with the nodejs implementation. In node-libs a lot of optional arguments are required, so we get an offset error in the browser calling buffer.readUInt32BE without an argument.