restructuring: added macros for stringification #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmileyAG
added
restructuring
high-priority
YaLTeR
reviewed
Jul 27, 2024
Comment on lines
+53
to
+54
| #define BXT_CONCATENATE(x, y) x##y | ||
| #define BXT_CONCATENATE_DETAIL(x, y) BXT_CONCATENATE(x, y) |
There was a problem hiding this comment.
Maybe just BXT_CONCAT()? Also what does "DETAIL" mean?
There was a problem hiding this comment.
what does "DETAIL" mean?
#define test RTY
BXT_TOSTRING(BXT_CONCATENATE(QWE, test)) // "QWEtest" string
BXT_TOSTRING(BXT_CONCATENATE_DETAIL(QWE, test)) // "QWERTY" stringThere was a problem hiding this comment.
Yeah but what does the word "DETAIL" have to do with this?
There was a problem hiding this comment.
What else should it be called then? BXT_CONCATENATE_EXPAND?
Both of these macros are valuable in different situations, so I didn't add the _ prefix like I did with _BXT_STRINGIFY, which emphasized that it was just a helper macro for another macro, but that's not the case here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most common
CONCAT,TOSTRINGand__func__macros, but wrapped in their own cover for increased compatibility and avoidance of unnecessary collisions.Necessary for future pull requests to making bizzare macros in modules to simplify coding in them.