minor: runtime_data: declared checksums structure #532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request does NOT solve the issue, but simply gives it a some start in resolving.
Hashes will be transmitted as strings instead of the hardcoded amount of allocated bytes for them, just so that if something happens we can easily change the hashing algorithm without consequences for this.
On the parser side, we can always check whether the string contains any other characters other than a-F and 0-9 as validity (basically to make sure that this string corresponds to hexadecimal format)
And a simple way on the parser side to determine the type of algorithm is by the number of characters (e.g. MD5 is 128 bit = 128 / 8 = 16 * 2 = 32 characters); this is could be used for comparison with some hardcoded list of hashes in parser side
We also need to return at least the logging name of the server module later, since modules logging was removed with this commit: 1d049ef
I also don’t see much point in logging the names of all loaded modules, but the name of the server module (
hl.dll
and etc) must be logged for the purpose to working with hardcoded list of hashes (e.g. since list might be formatted in way like:"server_module_name", "md5_hash", "sha1_hash", "sha256_hash"
)