fix(params): prevent parameter retrieval crashes in ROS2 #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check for node's fully qualified name to prevent deadlocks - Add 2.0s timeout to spin_until_future_complete - Fix crashes when retrieving parameters via Roslibjs Fixes RobotWebTools#972
sea-bass
reviewed
Jan 4, 2025
| @@ -238,7 +238,7 @@ def _get_param_names(node_name): | |||
| request = ListParameters.Request() | |||
| future = client.call_async(request) | |||
| if _node.executor: | |||
| _node.executor.spin_until_future_complete(future) | |||
| _node.executor.spin_until_future_complete(future, timeout_sec=2.0) | |||
There was a problem hiding this comment.
Changes look good, but this 2.0 may not hold in all cases. Wonder if should at least be a named constant instead of hard-coded, or even better an input argument to this function that comes from a configurable ROS parameter of the node?
There was a problem hiding this comment.
Also, would it help to add this timeout in the else case right below this as well, which does the same but with the global executor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Fixes #972