Allow PyGraph and PyDiGraph to be annotated as generic classes at runtime #1348
+101
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345. It should address the core aspects for
PyGraph
andPyDiGraph
. However, custom return types will come in a follow up PRThis makes the following work without requiring
from __future__ import annotations
:Also, this is worth highlighting: I refrained from addingI ended up adding the method to the stubs as__class_getitem__
to the type stubs as in the stubs that method is inherited fromGeneric[_S, _T]
mypy
stub tests disagreed with my reasoning