XSUB.h: simplify XS_INTERNAL/XS_EXTERNAL macros #22890
Merged
+1
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since `__attribute__unused__` was added to the XSPROTO definition, the explicit `defined(HASATTRIBUTE_UNUSED)` check has become redundant. Also, the XS_INTERNAL definitions are functionally equivalent in all branches, so replace them by a single unconditional definition.
tonycoz
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since
__attribute__unused__was added to the XSPROTO definition, the explicitdefined(HASATTRIBUTE_UNUSED)check has become redundant.Also, the XS_INTERNAL definitions are functionally equivalent in all branches, so replace them by a single unconditional definition.