Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.15 support #1711

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

1.15 support #1711

wants to merge 33 commits into from

Conversation

cetvrtak
Copy link
Collaborator

@cetvrtak cetvrtak commented Jan 2, 2025

No description provided.

@cetvrtak
Update blank_mod
850a997
@cetvrtak
Update version
f5e2e19
@cetvrtak
Update province mappings - vanilla & HPM
19c8e32
@cetvrtak
Add new provinces to configurables/Map/regions.txt
63f1305
@cetvrtak
Clean common/special_projects
ecb9100
@cetvrtak
Copy Vic3ToHoI4 common/raids
ab32e5d
@cetvrtak
Clean up error log
c8f33fc
@cetvrtak
Update buildings
6a36a58
@cetvrtak
Import landmarks mappings
c547108
@cetvrtak
Add landmarks mappings tests
8f3c945
@cetvrtak
Add landmark buildings to states
87819e4
@cetvrtak
Check if landmark has a name and is located in the state before adding
440cebb
@cetvrtak
Import default landmark buildings
2e8f912
@cetvrtak
Import enable_for_controllers as stringList & clean up
60d5bab
@cetvrtak
Store buildings as a map of pointers
e793a94
@cetvrtak
Add LandmarksMapper.cpp
4dabc9a
@cetvrtak
Update landmark buildings
bf3a563
@cetvrtak
Don't output unmapped landmark buildings
3b73e8a
@cetvrtak
Don't assign unbuilt landmarks to states
b299981
@cetvrtak
Clang, includes & braces
96c6cd4
@cetvrtak
Import default adjacency rules
876d8ac
@cetvrtak
Add adjacency rule tests
01787e3
@cetvrtak
Create and output adjacency rules
0d01d5c
@cetvrtak
Clang
5851320
@cetvrtak cetvrtak requested a review from Idhrendur as a code owner January 2, 2025 07:41
Idhrendur
Idhrendur reviewed Jan 3, 2025
View reviewed changes
src/Mappers/Buildings/LandmarksMapper.h Outdated Show resolved Hide resolved
src/Mappers/Buildings/LandmarksMapperFactory.h Outdated Show resolved Hide resolved
src/Mappers/Buildings/LandmarksMappingFactory.h Outdated Show resolved Hide resolved
src/Mappers/Buildings/LandmarksMappingTests.cpp Outdated Show resolved Hide resolved
src/Mappers/Buildings/LandmarksMappingTests.cpp Outdated Show resolved Hide resolved
src/Mappers/Buildings/LandmarksMapperTests.cpp Outdated Show resolved Hide resolved
Idhrendur
Idhrendur approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@Idhrendur Idhrendur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the first five lines in https://github.com/ParadoxGameConverters/Vic2ToHoI4/blob/master/docs/release_checklist.txt - if you need help picking a name for the next version let me know. I usually ask Zemurin to put together a banner.

Once that's all in and this is ready to merge let me know. I'll do the merge and tag all at once so the new build is placed in the new release.

src/Mappers/Buildings/LandmarksMapping.h Outdated Show resolved Hide resolved
src/HOI4World/States/HoI4StateTests.cpp Outdated Show resolved Hide resolved
src/HOI4World/Map/AdjacencyRulesTests.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Idhrendur Idhrendur Idhrendur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cetvrtak @Idhrendur