-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): port absorbance reader commands to state update #17113
Conversation
api/src/opentrons/protocol_engine/commands/absorbance_reader/close_lid.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17113 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 77 77
Lines 1283 1283
=======================================
Hits 1186 1186
Misses 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good and the porting over to state update passes immediate sight checks for the same kind of behavior we had implemented already. Test coverage also looks good, don't see anything missing there. Thanks for doing this Tamar!
state_update.files_added = update_types.FilesAddedUpdate(file_ids=file_ids) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic looks solid down through it's usage. We utilize the files added data at the end of a run on the client as when looking through the run result to populate the list of files available for download via the app after the fact, so this should maintain that logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Thank you for filling in the missing tests.
We're still missing tests for ModuleStateStore
, but that was the case before, and it certainly doesn't need to get fixed in this PR. It does mean that we have to be careful about reviewing the _handle_absorbance_reader_commands()
code by eye, though.
api/tests/opentrons/protocol_engine/commands/absorbance_reader/__init__.py
Outdated
Show resolved
Hide resolved
…/__init__.py Co-authored-by: Max Marrone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
Overview
absorbance reader part of module state update.
https://opentrons.atlassian.net/browse/EXEC-756.
adding missing command unit tests for absorbance reader.
Test Plan and Hands on Testing
upload a protocol using the absorbance reader.
make sure all commands are working as expected.
make sure state is updated as expected.
Changelog
Review requests
Risk assessment
low (if I did this properly). module state updates and missing tests.