Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: ERC721Wrapper extension #461

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

programskillforverification
Copy link
Contributor

Resolves #359

PR Checklist

  • Tests
  • Documentation
  • Changelog

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 195ced3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67726ce301658c00088f6bb9

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.3%. Comparing base (3205fc7) to head (195ced3).

Files with missing lines Patch % Lines
contracts/src/token/erc721/extensions/wrapper.rs 0.0% 31 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc721/extensions/wrapper.rs 0.0% <0.0%> (ø)

#[storage]
pub struct Erc721Wrapper {
/// Erc721 contract storage.
pub _underlying: Erc721,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bidzyyys What should the type of _underlying be?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably be using pub _underlying: Address, as this is an external contract, and Stylus currently has no way to represent them as part of structs.

You'll then also probably need to define a local sol interface, like in VestingWallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC721Wrapper extension
3 participants