Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: display the application date in the chosen language #10265

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SarahBellaha
Copy link
Contributor

Closes #10012

@SarahBellaha SarahBellaha requested a review from a team as a code owner January 7, 2025 08:16
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (b09fc36) to head (3c81b97).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10265      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104282   104283       +1     
  Branches      722      722              
==========================================
- Hits        84936    84923      -13     
- Misses      19305    19319      +14     
  Partials       41       41              
Flag Coverage Δ
editoast 73.57% <ø> (-0.05%) ⬇️
front 89.18% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well, maybe you can also adapt the date so it can be displayed in the chosen language for anterior and posterior train

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LMR : Application date in the simulation report sheet appears in french when the document is in english
4 participants