Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display correct ch code after linked train selection #10235

Merged

Conversation

SarahBellaha
Copy link
Contributor

Closes #10033

@SarahBellaha SarahBellaha requested a review from a team as a code owner January 6, 2025 08:47
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (b09fc36) to head (a465be7).
Report is 26 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10235      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104282   104283       +1     
  Branches      722      722              
==========================================
- Hits        84936    84925      -11     
- Misses      19305    19317      +12     
  Partials       41       41              
Flag Coverage Δ
editoast 73.57% <ø> (-0.05%) ⬇️
front 89.18% <88.88%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba/front/ch-code-not-set-on-linked-train-selection branch from 2defcd8 to a465be7 Compare January 7, 2025 04:36
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested !!!

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SarahBellaha SarahBellaha added this pull request to the merge queue Jan 8, 2025
Merged via the queue into dev with commit 5a3511e Jan 8, 2025
28 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/ch-code-not-set-on-linked-train-selection branch January 8, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: selecting a linked train doesn't set the ch code
4 participants