Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shorter message in v3 upgrade dialog #7690

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

frankqianms
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #7690 (62a05cb) into dev (4aaa1c2) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7690      +/-   ##
==========================================
+ Coverage   77.19%   77.23%   +0.04%     
==========================================
  Files         592      592              
  Lines       40196    40192       -4     
  Branches     7842     7843       +1     
==========================================
+ Hits        31031    31044      +13     
+ Misses       5856     5834      -22     
- Partials     3309     3314       +5     
Impacted Files Coverage Δ
packages/server/src/serverConnection.ts 85.00% <0.00%> (-0.22%) ⬇️
...ackages/fx-core/src/component/coordinator/index.ts 80.28% <0.00%> (-0.21%) ⬇️
packages/server/src/apis.ts 100.00% <0.00%> (ø)
packages/vscode-extension/src/handlers.ts 46.20% <0.00%> (+<0.01%) ⬆️
packages/fx-core/src/component/question.ts 77.57% <0.00%> (+1.40%) ⬆️
packages/fx-core/src/core/question.ts 75.86% <0.00%> (+2.28%) ⬆️
...fx-core/src/component/utils/ResourceGroupHelper.ts 63.84% <0.00%> (+3.84%) ⬆️

@frankqianms frankqianms merged commit ecf7bf8 into dev Feb 6, 2023
@frankqianms frankqianms deleted the frank/shorter-message-in-upgrade-dialog branch February 6, 2023 09:30
@therealjohn
Copy link
Contributor

I have changes to this message and many others in #7425. However, this PR would make this message shorter than my suggestion - is there a technical reason it needs to be shorter?

@frankqianms
Copy link
Contributor Author

I have changes to this message and many others in #7425. However, this PR would make this message shorter than my suggestion - is there a technical reason it needs to be shorter?

Yes. We've talked with PMs, and we agreed that long messages will annoy users and decrease their wills to upgrade. There should be only two key points in the messages: 1. To tell users that they can not develop their pjs with new extension, so that they have to upgrade pjs, 2. To tell users that there will be backups and decrease their worries of upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants