Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved uuidObject.ts from internal to public folder in preparation for exporting it #2671

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

erinha
Copy link
Contributor

@erinha erinha commented Jan 8, 2025

Description

Moved uuidObject.ts from internal to public folder in preparation for exporting it.

The UUID type needs to be exported as part of this PR: https://github.com/OfficeDev/microsoft-teams-library-js/pull/2654/files, and in the spirit of small, isolated changes, I'm doing the move separately from the logical changes in the file that will come as part of the other PR.

Main changes in the PR:

  1. Move uuidObject.ts from internal to public.
  2. Update import references.

Validation

Validation performed:

  1. Unit tests pass.

Unit Tests added:

No, this is just a refactor.

End-to-end tests added:

No

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

Related PRs:

Added customTelemetry subcapability under copilot

@erinha erinha requested a review from a team as a code owner January 8, 2025 20:08
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@erinha erinha merged commit af5af5a into main Jan 8, 2025
39 checks passed
@erinha erinha deleted the erinha/uuidMove branch January 8, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants