Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Fix texture lock when doing Shift+Drag to clone brushes #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericwa
Copy link
Contributor

@ericwa ericwa commented Dec 1, 2015

I noticed that doing Shift+Drag to clone brushes with the Select Tool wasn't using texture lock, even if texture lock was enabled.

The cause was, face.Texture.Texture was null when the transformation was applied to the cloned brushes. I copied this from OperationsPasteSpecial()... doesn't feel like a great fix, but at least it's something.

@ericwa
Copy link
Contributor Author

ericwa commented Dec 1, 2015

Hm.. that wasn't quite enough, for a more complex case where faces have texture shifts and scales set, I also need to add a call to face.CalculateTextureCoordinates(true); there, like the PartialPostLoadProcess method does.

@LogicAndTrick
Copy link
Owner

Thanks for this, I've been busy on another project so I'll leave this open until I can get back into Sledge early next year. I'm not too happy with how textures are working right now, so hopefully I can avoid this problem by changing some of the messy code in other areas. This fix looks like it'll work until then, though.

@ericwa
Copy link
Contributor Author

ericwa commented Dec 1, 2015

Cool, totally understand. :-)

I do also have an improved version of my quake texture patch, that loads the palette from the game data (even supports hexen 2 for free), and I got a simple quake .mdl loader working too. I'll probably make PR's for them soon but no worries if you can't look at them until next year.

@LogicAndTrick
Copy link
Owner

That sounds awesome, looking forward to seeing them!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants