Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial conversion to ESM module #362

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Initial conversion to ESM module #362

merged 10 commits into from
Jun 18, 2024

Conversation

lyricnz
Copy link
Contributor

@lyricnz lyricnz commented Jun 16, 2024

Per #361

TLDR:

  • append .js to all local imports
  • use node:fs not fs
  • a couple of require -> import for dynamic imports; add .js suffix
  • kludge to emulate __dirname
  • rename/update webpack config
  • change type etc in package.json
  • fix? webpack step ordering

Then:

  • Update to chai@5 and chai-as-promised@8
  • Update all other modules

@lyricnz
Copy link
Contributor Author

lyricnz commented Jun 16, 2024

@lyricnz
Copy link
Contributor Author

lyricnz commented Jun 18, 2024

@lyricnz lyricnz merged commit 4ea926b into develop Jun 18, 2024
4 checks passed
@lyricnz lyricnz deleted the feature/esm-project branch June 18, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants