-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streamrip 2.0.5 (new formula) #203235
streamrip 2.0.5 (new formula) #203235
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Bit confused out here - any help would be appreciated. Pillow builds just fine on my local machine. brew audit --strict --online streamrip: zero output. brew doctor:
The differences in streamrip rb here and my commit are a total of zero. I admittedly ended up uploading through the GitHub GUI, is why it's reported. brew config:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, please take a look.
Some of python packages are pre-build as a homebrew formula like certifi
and pillow
, so you don't need to built it again. To prevent the packages are automatically added, they have to be excluded by adding them to the file below.
Thank you for the contribution, @Red6785 🎉 |
2240364
to
c459e74
Compare
Thanks so much for all the assistance! Is there anything else I have to do from here? |
Adds a new formula to homebrew, streamrip, a scriptable music downloader.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?