Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamrip 2.0.5 (new formula) #203235

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Conversation

Red6785
Copy link
Contributor

@Red6785 Red6785 commented Jan 5, 2025

Adds a new formula to homebrew, streamrip, a scriptable music downloader.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@Red6785
Copy link
Contributor Author

Red6785 commented Jan 5, 2025

Bit confused out here - any help would be appreciated. Pillow builds just fine on my local machine.
First time contributor here.

brew audit --strict --online streamrip: zero output.
brew audit --new streamrip: zero output.
brew style streamrip: 1 file inspected, no offenses detected

brew doctor:

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  streamrip

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /opt/homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
   M Formula/s/streamrip.rb
  ?? .DS_Store
  ?? Formula/.DS_Store
  ?? Formula/s/.DS_Store

Warning: Some taps are not on the default git origin branch and may not receive
updates. If this is a surprise to you, check out the default branch with:
  git -C $(brew --repo homebrew/core) checkout master

The differences in streamrip rb here and my commit are a total of zero. I admittedly ended up uploading through the GitHub GUI, is why it's reported.

brew config:

ORIGIN: https://github.com/Homebrew/brew
HEAD: 683f85f4b0bae08beb1edf8e672f0ee726efed51
Last commit: 11 hours ago
Branch: master
Core tap HEAD: 4d7e15813a4c9cca6aa480f8c581be5ab509b890
Core tap last commit: 49 minutes ago
Core tap branch: streamrip-formula
Core tap JSON: 05 Jan 01:27 UTC
Core cask tap HEAD: caacd9e842f1e843d1b31c629652c6dc0005e4bd
Core cask tap last commit: 77 minutes ago
Core cask tap JSON: 05 Jan 01:27 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_INSTALL_BADGE: ☕
HOMEBREW_MAKE_JOBS: 14
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.6 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: 14-core 64-bit arm_brava
Clang: 16.0.0 build 1600
Git: 2.47.1 => /opt/homebrew/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 15.2-arm64
CLT: 16.2.0.0.1.1733547573
Xcode: N/A
Rosetta 2: false

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, please take a look.

Some of python packages are pre-build as a homebrew formula like certifi and pillow, so you don't need to built it again. To prevent the packages are automatically added, they have to be excluded by adding them to the file below.

Formula/s/streamrip.rb Outdated Show resolved Hide resolved
Formula/s/streamrip.rb Outdated Show resolved Hide resolved
Formula/s/streamrip.rb Outdated Show resolved Hide resolved
Formula/s/streamrip.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 5, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Jan 5, 2025

Thank you for the contribution, @Red6785 🎉

@Red6785
Copy link
Contributor Author

Red6785 commented Jan 5, 2025

Thanks so much for all the assistance! Is there anything else I have to do from here?

@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Jan 5, 2025
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 5, 2025
@chenrui333
Copy link
Member

Thanks @Red6785, @daeho-ro!

Copy link
Contributor

github-actions bot commented Jan 5, 2025

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 5, 2025 15:33
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2025
Merged via the queue into Homebrew:master with commit 2053f3b Jan 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants