Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line length violations in abci.proto and CI environment notes #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link

@devin-ai-integration devin-ai-integration bot commented Jan 3, 2025

Description

This PR addresses remaining issues in the main branch to ensure compliance with contributing guidelines:

  1. Fixed line length violations in abci.proto:

    • Shortened comments while maintaining semantic meaning
    • Improved formatting for better readability
    • Verified PROTOCOL_GENERATOR_VERSION compatibility (using framework version 1.0.0)
  2. Fixed protocol generation issues:

    • Renamed CheckTxTypeEnum to CheckTxType for proper UpperCamelCase naming
    • Fixed line wrapping for response_apply_snapshot_chunk
    • Ensured consistent formatting throughout the file
  3. Resolved license compatibility issue:

    • Added attrs package (>=24.3.0) to authorized packages list
    • Verified MIT license compatibility
    • Ensured proper license check configuration

Note on CI Environment

The MacOS-12 environment in GitHub Actions is deprecated. GitHub recommends upgrading to:

  • macOS-13
  • macOS-14 (macos-latest)
  • macOS-15

Reference: actions/runner-images#10721
This infrastructure change requires maintainer approval.

Testing

  • Verified line length fixes in abci.proto
  • Confirmed PROTOCOL_GENERATOR_VERSION compatibility
  • Verified attrs package license configuration
  • Pushed changes to origin for CI verification

Link to Devin run: https://app.devin.ai/sessions/3311a8ec4a834cd3939fe3a353976093

Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants