Skip to content

Commit

Permalink
Merge pull request atom#20989 from NotMoni/NotMoni-fix-typos
Browse files Browse the repository at this point in the history
Fix Typos
  • Loading branch information
lkashef authored Jun 26, 2020
2 parents f9a9e57 + 32bd100 commit aa3c34b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion docs/rfcs/001-updatable-bundled-packages.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ The primary drawback of this approach is that Updatable bundled packages might e

### Increased Atom startup time

Another major drawback is that the snapshotted code for the bundled package will no longer be used since a newer version has been installed. This updated version of the package cannot be easily added back into Atom's snapshot so it could cause a noticable drag on Atom's startup time. Some quick measurements with Timecop show a 10x increase in GitHub package load time for bundled (snapshot) vs updated (non-snapshot) package code:
Another major drawback is that the snapshotted code for the bundled package will no longer be used since a newer version has been installed. This updated version of the package cannot be easily added back into Atom's snapshot so it could cause a noticeable drag on Atom's startup time. Some quick measurements with Timecop show a 10x increase in GitHub package load time for bundled (snapshot) vs updated (non-snapshot) package code:

| GitHub Package Code | Load Time |
|----------------------------------|-----------|
Expand Down
6 changes: 3 additions & 3 deletions src/grammar-registry.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ module.exports = class GrammarRegistry {
// * `buffer` The {TextBuffer} whose grammar will be set.
// * `grammar` The desired {Grammar}.
//
// Returns a {Boolean} that indicates whether the assignment was sucessful
// Returns a {Boolean} that indicates whether the assignment was successful
assignGrammar(buffer, grammar) {
if (!grammar) return false;
if (buffer.getBuffer) buffer = buffer.getBuffer();
Expand Down Expand Up @@ -547,7 +547,7 @@ module.exports = class GrammarRegistry {
// * `grammarPath` A {String} absolute file path to a grammar file.
// * `callback` A {Function} to call when loaded with the following arguments:
// * `error` An {Error}, may be null.
// * `grammar` A {Grammar} or null if an error occured.
// * `grammar` A {Grammar} or null if an error occurred.
loadGrammar(grammarPath, callback) {
this.readGrammar(grammarPath, (error, grammar) => {
if (error) return callback(error);
Expand All @@ -572,7 +572,7 @@ module.exports = class GrammarRegistry {
// * `grammarPath` A {String} absolute file path to a grammar file.
// * `callback` A {Function} to call when read with the following arguments:
// * `error` An {Error}, may be null.
// * `grammar` A {Grammar} or null if an error occured.
// * `grammar` A {Grammar} or null if an error occurred.
//
// Returns undefined.
readGrammar(grammarPath, callback) {
Expand Down
2 changes: 1 addition & 1 deletion src/ripgrep-directory-searcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function processUnicodeMatch(match) {

// This function processes a ripgrep submatch to create the correct
// range. This is mostly needed for multi-line results, since the range
// will have differnt start and end rows and we need to calculate these
// will have different start and end rows and we need to calculate these
// based on the lines that ripgrep returns.
function processSubmatch(submatch, lineText, offsetRow) {
const lineParts = lineText.split('\n');
Expand Down
2 changes: 1 addition & 1 deletion src/text-editor-component.js
Original file line number Diff line number Diff line change
Expand Up @@ -1868,7 +1868,7 @@ module.exports = class TextEditorComponent {
// keydown(code: X), keypress, keydown(code: X)
//
// The code X must be the same in the keydown events that bracket the
// keypress, meaning we're *holding* the _same_ key we intially pressed.
// keypress, meaning we're *holding* the _same_ key we initially pressed.
// Got that?
didKeydown(event) {
// Stop dragging when user interacts with the keyboard. This prevents
Expand Down
2 changes: 1 addition & 1 deletion src/text-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ module.exports = class TextEditor {
// * __cursor__: Render a cursor at the head of the {DisplayMarker}. If multiple cursor decorations
// are created for the same marker, their class strings and style objects are combined
// into a single cursor. This decoration type may be used to style existing cursors
// by passing in their markers or to render artificial cursors that don't actaully
// by passing in their markers or to render artificial cursors that don't actually
// exist in the model by passing a marker that isn't associated with a real cursor.
//
// ## Arguments
Expand Down
2 changes: 1 addition & 1 deletion src/uri-handler-registry.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const { Emitter, Disposable } = require('event-kit');
// is triggered. If you need your package to activate right away, you can add
// `"deferActivation": false` to your "uriHandler" configuration object. When activation
// is deferred, once Atom receives a request for a URI in your package's namespace, it will
// activate your pacakge and then call `methodName` on it as before.
// activate your package and then call `methodName` on it as before.
//
// If your package specifies a deprecated `urlMain` property, you cannot register URI handlers
// via the `uriHandler` key.
Expand Down

0 comments on commit aa3c34b

Please sign in to comment.